Support configurable ShouldPing func when acquiring conns#2362
Merged
Conversation
christiankiely
force-pushed
the
shouldping
branch
from
1bd272d to
f43091f
Compare
Owner
|
Thanks! |
Contributor
|
@jackc, hey, 👋 Could you please create a release that includes this change? This is a requirement for us to migrate from v4 to v5, as it resolves the PgBouncer compatibility issue that's currently blocking our upgrade. |
Owner
|
@ilyam8 v5.7.6 was just released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the suggested approach in #1738.
Allowing ShouldPing to be configurable will allow us to change the threshold for Pings on acquiring a conn, or disable it entirely.